Clean whitespace errors in gnupg repos (was Re: [PATCH] Spelling: correct spelling of "passphrase")

Andre Heinecke aheinecke at intevation.de
Wed Nov 2 19:46:42 CET 2016


Hi,

On Wednesday 02 November 2016 12:48:00 Daniel Kahn Gillmor wrote:
> I also note that the original (replaced) line itself had trailing
> whitespace.  If the goal is no trailing whitespace, and you want people
> to enforce this, perhaps it'd be worthwhile to do a global trailing
> whitespace cleanup?

Yes! Please! I know it makes history / blame a bit harder but not really a 
problem. In KDE we had coding style changes that changed nearly every line but 
I can still work with git to figure out the history. We should do this in all 
gnupg repos imo, maybe combined with an astyle run.

I find it very annoying in GpgOL (tons of whitespace errors) that this was 
never done. Makes patches harder and whitespace errors are highlighted in my 
editor so I "want" to fix them automatically and its irritating to ignore 
theese highlights.

Regards,
Andre

-- 
Andre Heinecke |  ++49-541-335083-262  | http://www.intevation.de/
Intevation GmbH, Neuer Graben 17, 49074 Osnabrück | AG Osnabrück, HR B 18998
Geschäftsführer: Frank Koormann, Bernhard Reiter, Dr. Jan-Oliver Wagner
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: This is a digitally signed message part.
URL: </pipermail/attachments/20161102/010b641c/attachment.sig>


More information about the Gnupg-devel mailing list