[PATCH v3 3/5] gpg-agent: Implement --supervised command (for systemd, etc).

NIIBE Yutaka gniibe at fsij.org
Mon Nov 21 03:17:34 CET 2016


On 10/05/2016 04:20 PM, Werner Koch wrote:
> On Wed,  5 Oct 2016 06:51, dkg at fifthhorseman.net said:
> 
>> I've tested this and there are a few problems still aside from the
>> patch i've sent to the list.
> 
> My fault.  I had to rebase my commits before pushing.  This required
> some manual edits and although I recall that I added initialize_modules
> to the supervised mode, that somehow got lost.

Sorry, I should have be more careful after the rebased commit and the
fix.

My commit eda17649f8bd3b8ce7bfc00a3c11cbcae63c845d did this once
(moving initialization).  Then, the rebased commit
9f92b62a51d2d60f038fdbe01602865c5933fa95 inserted it for parent.

The fix f57dc2b1e6f28d164f882373535dbcb0d632ca17 added
initialized_modules for --supervised.

Here is a patch to remove initialized_modules for --daemon.

diff --git a/agent/gpg-agent.c b/agent/gpg-agent.c
index 1433f7f..175866d 100644
--- a/agent/gpg-agent.c
+++ b/agent/gpg-agent.c
@@ -1473,8 +1473,6 @@ main (int argc, char **argv )
       pid_t pid;
 #endif

-      initialize_modules ();
-
       /* Remove the DISPLAY variable so that a pinentry does not
          default to a specific display.  There is still a default
          display when gpg-agent was started using --display or a
-- 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 455 bytes
Desc: OpenPGP digital signature
URL: </pipermail/attachments/20161121/f83b40c8/attachment.sig>


More information about the Gnupg-devel mailing list