[PINENTRY PATCH] tty button-related fixes and refinements

NIIBE Yutaka gniibe at fsij.org
Mon Oct 3 09:06:29 CEST 2016

On 09/27/2016 01:02 PM, Ineiev wrote:
> On Fri, Apr 08, 2016 at 01:47:38PM -0400, Ineiev wrote:
>> I attach some fixes I've come up with when playing with non-ASCII
>> texts in buttons.
>> The first one simplifies key checking code a little bit; the second
>> one fixes a few bugs in underscore processing; the third one lets
>> the user see the localized message even if the pinentry doesn't
>> support its accelerators (by the way, I think that pinentry
>> should localize the messages that aren't customized from the agent,
>> like "Press any key to continue."); the last one adds a default
>> message to a call of button() so that pinentry won't skip a button
>> when its text is localized.
> I've fixed a few typos in comments and log messages.

Thank you for your fixes.

I applied three bug fixes, with commit message edit by me.


For 0001, I modified your change a bit to keep the output for input
key is as same as before.

The patch:


is introducing a new feature.  Let me have (more) time to review this

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 455 bytes
Desc: OpenPGP digital signature
URL: </pipermail/attachments/20161003/1f0e5317/attachment.sig>

More information about the Gnupg-devel mailing list