[PATCH HEAD] a typo in a message
Daniel Kahn Gillmor
dkg at fifthhorseman.net
Thu Oct 6 16:29:57 CEST 2016
On Thu 2016-10-06 02:43:41 -0400, Ineiev wrote:
> On Wed, Oct 05, 2016 at 06:55:51PM +0200, Werner Koch wrote:
>> On Wed, 5 Oct 2016 16:36, ineiev at gnu.org said:
>>
>> > - log_info (_("WARNING: Encrypting to %s, which has no"
>> > + log_info (_("WARNING: Encrypting to %s, which has no "
>> > "non-revoked user ids.\n"),
>>
>> Although "no non-" is technically correct, it is hard to grok. Should
>> be re-worded. And we do not print dots at the end.
>
> Just a try:
>
> diff --git a/g10/tofu.c b/g10/tofu.c
> index 1bd8ce2..9fb70c1 100644
> --- a/g10/tofu.c
> +++ b/g10/tofu.c
> @@ -3052,8 +3052,8 @@ tofu_register_encryption (ctrl_t ctrl,
> free_user_id_list = 1;
>
> if (! user_id_list)
> - log_info (_("WARNING: Encrypting to %s, which has no"
> - "non-revoked user ids.\n"),
> + log_info (_("WARNING: Encrypting to %s, "
> + "a key with all user IDs revoked\n"),
> keystr (pk->keyid));
> }
I'm not sure about this. The other case could be a key that has no user
IDs at all, right? Maybe we need a different message for the two cases?
--dkg
More information about the Gnupg-devel
mailing list