[PATCH v3 3/5] gpg-agent: Implement --supervised command (for systemd, etc).

[Daniel Kahn Gillmor]

On Wed 2016-10-05 03:20:20 -0400, Werner Koch wrote:
> On Wed,  5 Oct 2016 06:51, dkg at fifthhorseman.net said:
>
>> I've tested this and there are a few problems still aside from the
>> patch i've sent to the list.
>
> My fault.  I had to rebase my commits before pushing.  This required
> some manual edits and although I recall that I added initialize_modules
> to the supervised mode, that somehow got lost.
>
> I pushed a fix.


Thanks.  with these fixes, i now consistently get the abort, regardless of
the valud of the log-file directive :)

the backtrace on the abort is:


Program received signal SIGABRT, Aborted.
__GI_raise (sig=sig at entry=6) at ../sysdeps/unix/sysv/linux/raise.c:58
58	../sysdeps/unix/sysv/linux/raise.c: No such file or directory.
(gdb) bt
#0  __GI_raise (sig=sig at entry=6) at ../sysdeps/unix/sysv/linux/raise.c:58
#1  0x00007fd5d80f240a in __GI_abort () at abort.c:89
#2  0x00007fd5d812ebd0 in __libc_message (do_abort=do_abort at entry=2, fmt=fmt at entry=0x7fd5d8223c10 "*** Error in `%s': %s: 0x%s ***\n") at ../sysdeps/posix/libc_fatal.c:175
#3  0x00007fd5d8134fa6 in malloc_printerr (action=3, str=0x7fd5d822080b "malloc(): memory corruption", ptr=<optimized out>, ar_ptr=<optimized out>) at malloc.c:5046
#4  0x00007fd5d8136f79 in _int_malloc (av=av at entry=0x7fd5d8456b00 <main_arena>, bytes=bytes at entry=720) at malloc.c:3509
#5  0x00007fd5d81399ab in __libc_calloc (n=<optimized out>, elem_size=<optimized out>) at malloc.c:3271
#6  0x00007fd5d88872cc in parse_format (max_argspecs=5, r_argspecs_count=<synthetic pointer>, argspecs_addr=<synthetic pointer>, format=0x5603f0738562 "02d ") at ../../src/estream-printf.c:672
#7  _gpgrt_estream_format (outfnc=outfnc at entry=0x7fd5d8882fd0 <print_writer>, outfncarg=outfncarg at entry=0x5603f0fc2d40, format=0x5603f0738548 "%04d-%02d-%02d %02d:%02d:%02d ", vaargs=0x7ffe45981e90, 
    vaargs at entry=0x7ffe45981e80) at ../../src/estream-printf.c:1506
#8  0x00007fd5d8885508 in es_print (ap=ap at entry=0x7ffe45981e80, format=<optimized out>, stream=0x5603f0fc2d40) at ../../src/estream.c:2939
#9  _gpgrt_vfprintf_unlocked (stream=0x5603f0fc2d40, format=<optimized out>, ap=ap at entry=0x7ffe45981e90) at ../../src/estream.c:4382
#10 0x00007fd5d8889b34 in gpgrt_fprintf_unlocked (stream=<optimized out>, format=format at entry=0x5603f0738548 "%04d-%02d-%02d %02d:%02d:%02d ") at ../../src/visibility.c:570
#11 0x00005603f071baa6 in do_logv (level=level at entry=2, ignore_arg_ptr=ignore_arg_ptr at entry=0, fmt=0x5603f072fec8 "using fd %d for %s socket (%s)\n", arg_ptr=arg_ptr at entry=0x7ffe45981fd0) at ../../common/logging.c:673
#12 0x00005603f071c943 in log_info (fmt=<optimized out>) at ../../common/logging.c:817
#13 0x00005603f06f6525 in map_supervised_sockets (r_fd_ssh=<optimized out>, r_fd_browser=<optimized out>, r_fd_extra=<optimized out>, r_fd=<optimized out>) at ../../agent/gpg-agent.c:755
#14 main (argc=<optimized out>, argv=<optimized out>) at ../../agent/gpg-agent.c:1484
(gdb)

        --dkg