[gpgme][PATCH] build: lang: python: cleanups
justus at g10code.com
Mon Sep 26 11:02:00 CEST 2016
thanks for the patch.
Alon Bar-Lev <alon.barlev at gmail.com> writes:
> 1. Make setup.py executable when generated.
Please fix one issue per patch, that makes it way easier to review and
> 2. Add prepare target to enable prepare the source tree without building
> anything. This is handy to enable standard distutils build outside of
> gpgme build system.
That is a good idea indeed.
> 3. Treat data.h in similar manner as other VPATH issues, just copy it to
> the srcdir to simplify build, remove the CFLAGS requirement of
No. Including data.h a hack, and the proper solution is to create a
proper API so that we don't need the layout of struct gpgme_data. Also,
we don't relay the CFLAGS merely to locate data.h, we also like to
compile the glue code with the very same CFLAGS.
> 4. Add environment variable (binary_builddir) for setup to use alternate
> build directory so that for multiple targets same binaries may be
> used without rebuilding the C part.
I guess we could do that, yes.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 454 bytes
Desc: not available
More information about the Gnupg-devel