[PATCH GPGME] python: build: reinstate prepare target

[Justus Winter]

Alon Bar-Lev <alon.barlev at gmail.com> writes:

> On 29 March 2017 at 12:34, Justus Winter <justus at g10code.com> wrote:
>> However, in the future, even if you cannot be bothered to read our
>> commit message guidelines, please just try to make your message blend in
>> with the others.
>
> I truly tried!!!

Sorry.  To my eyes, your commit message looks so out-of-place.  We are
really mostly just following GNU changelog rules.  The commit messages
of every GNU project I have contributed to are looking more or less like
this.

> What have I missed this time?

Here we go:

> python: build: reinstate prepare target
  ^       ^ multiple components, better join them with comma.
                 ^ Please use whole sentences, start with a capital
                   letter, end with a full-stop.

> * lang/python/Makefile.am: fix prepare target
                           ^ Usually, giving some (context) is good, but
                             this is tricky with Makefiles.
                             ^ Please use whole sentences, start with
                               a capital letter, end with a full-stop.

> * lang/python/setup.py.in: abs_top_builddir handling
                             ^ Please use whole sentences, start with
                               a capital letter, end with a full-stop.

> prepare will prepare target at PREPAREDIR
  ^ Please use whole sentences, start with a capital letter, end with a
    full-stop.  Please reflow this text (meta-q).
> the automake will make use of prepare target
  ^ Likewise.
> downstream may also make use of prepare target
  ^ Likewise.
> outcome of splitting it is standard make error checking for each command
  ^ Likewise.
>
> running setup.py in-tree requires abs_top_builddir environment to be set
> to avoid guessing process.
  ^ Likewise.

Justus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 487 bytes
Desc: not available
URL: </pipermail/attachments/20170329/535105f1/attachment.sig>