[PATCH 1/5] cpp: expose minimal key export flag from C

Thorsten Behrens thb at libreoffice.org
Thu Feb 1 14:37:27 CET 2018

Werner Koch wrote:
> I noticed things like
> -#      ifdef WIN32
> +#      ifdef _MSC_VER
>  #       define GPGMEPP_EXPORT __declspec(dllexport)
Hmm - but WIN32 is an equally-bad choice, since it's only defined for
mingw builds.

Looking at https://gist.github.com/jonforums/968522, how about going
with _WIN32 for the while?

> After all this boils down to the question whether and how we want to
> support native building and - worse - on a really strange
> combination of platforms.
The platform - when it comes to compiler and linker, i.e. all pieces
that touch the actual code - is pretty standard msvc. All patches
submitted against _that_ goal IMO improve portability quite a bit (if
you look closer, there were some nonsense calls to posix functions in
Windows-only code, where then the mingw libc silently drops stuff -
I'd much prefer this to be visible in plain sight).

I admit the build system I had to shoehorn that into is weird; then
again that can be said about autotools, too ... ;)


-- Thorsten
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 949 bytes
Desc: Digital signature
URL: <https://lists.gnupg.org/pipermail/gnupg-devel/attachments/20180201/121c584b/attachment.sig>

More information about the Gnupg-devel mailing list