[PATCH libgpg-error] doc: clarify patch submission workflow

Todd Zullinger tmz at pobox.com
Thu Feb 1 21:41:42 CET 2018


I wrote:
> I think it would be better to suggest setting the
> format.subjectPrefix option to make this easier.  E.g.:
> 
>     $ git config format.subjectPrefix 'PATCH/libgpg-error'

And here's that suggestion in unified diff format (along
with automation of the git send-email --to=... option).
Feel free to squash this in with or without attribution.  I
don't think this warrants a signoff or DCO from me, but I'm
happy to provide one if needed.

-->8--
diff --git i/doc/HACKING w/doc/HACKING
index d379099..9d552b7 100644
--- i/doc/HACKING
+++ w/doc/HACKING
@@ -57,18 +57,21 @@
 
   - if you're working from the git repo, here's a suggested workflow:
 
+    - configure git send-email defaults:
+
+        git config format.subjectPrefix 'PATCH/libgpg-error'
+        git config sendemail.to gnupg-devel at gnupg.org
+
     - hack hack hack
 
     - commit your changes; group changes into easily-reviewable commit
       units, feel free to submit several patches at once
 
     - e.g. if you want to submit a single patch on top of master, do:
-      git send-email --to=gnupg-devel at gnupg.org --annotate -1
-      (please put a mention of libgpg-error into the subjects,
-      annotate lets you do that)
+      git send-email --annotate -1
 
     - e.g. if you have two commits on top of master, do:
-      git send-email --to=gnupg-devel at gnupg.org --annotate --cover-letter -2
+      git send-email --annotate --cover-letter -2
       (that prompts you for a summary mail to precede your actual
       patch mails)
 
-- 
Todd
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
You cannot propel yourself forward by patting yourself on the back.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 543 bytes
Desc: not available
URL: <https://lists.gnupg.org/pipermail/gnupg-devel/attachments/20180201/b5b72ff1/attachment-0001.sig>


More information about the Gnupg-devel mailing list