[PATCH scute] Build a second library which uses the signing key.

[Dirk Gottschalk]

Hi.

Am Samstag, den 19.05.2018, 20:43 +0100 schrieb Damien Goutte-Gattat:
> Hi,
> 
> > This patch introduces the configure switch --enable-sigkey which
> > enables building of scutesig.so which uses the signature key.
> 
> Thanks.
> 
> However I propose (see the patch below) a slightly modified version
> in which the --enable-signing-key flag simply changes the key to
> use from the authentication key to the signing key, without building
> a second library. This avoid further code duplication in
> src/Makefile.am and makes a less intrusive patch.

Yes, but...


> If you need both a scute using the authentication key and a scute
> using the signing key, then you just have to configure and build
> twice (first without the --enable-signing-key flag, then with it)
> and rename one of the two libraries accordingly.

...this was the Problem in my case. I needed both and needed them to
coexist. Different names of the shared object help me to differ both of
them. I tried to make the name of the library file conditional, but
autotools don't like this and I also had to duplicate the instructions
in Makefila.am in this case.

I agree that this is not the best possible way.

The perfect way would be to put both in one library, but, after viewing
the code, I think this is basically not possible, since this is a
Mozilla-Plugin and so it is bound to the functions which are called by
Firefox, Thunderbird, LibreOffice and so on.

I don't like the idea of renaming the libraries after installation, but
it seems the best way to avoid duplicate code. An alternative to
renaming would be to define a different --libdir=*** while configuring
the package and install into different sub-directories. I think this
should be the recommended way to install both libraries on the same
system. Renaming the files could increase the risk of mistakes made by
user.

Regards,
Dirk

-- 
Dirk Gottschalk
Paulusstrasse 6-8
52064 Aachen
Tel.: +49 1573 1152350
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part
URL: <https://lists.gnupg.org/pipermail/gnupg-devel/attachments/20180520/735fbfae/attachment.sig>