[GPA][PATCH] option->description in confdialog.c

Ineiev ineiev at gnu.org
Tue May 22 11:54:26 CEST 2018


Hello,

On Sat, Mar 26, 2016 at 05:43:38AM -0400, Ineiev wrote:
> 
> I was testing i18n in GPA and noticed that some group labels are
> truncated; I cheched confdialog.c and found out that there is
> a 80-character limit for them:
> ...
>  	{
>  	  if (option->flags & GPGME_CONF_GROUP)
>  	    {
> 	      char name[80];
> ...
> 
> Now, if we use Cyrillics it's only 40 letters, which tends to be
> insufficient for Slavic languages; I'd suggest allocating memory
> dynamically.
> 
> Then, I saw that commas in the labels are shown as '%2c', in
> other words, the descriptions should be unescaped (this also applies
> to other pieces of confdialog.c). (I used current GPGME HEAD.)
> 
> At last, there is a bug in the percent_unescape function itself:
> the resulting string is not closed by '\0' in its end, and when
> the unescaping is not trivial, the the string shows a duplicate tail.

Rebased against current HEAD, split into 3 patches.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-percent-unescaping.patch
Type: text/x-diff
Size: 719 bytes
Desc: not available
URL: <https://lists.gnupg.org/pipermail/gnupg-devel/attachments/20180522/291fb120/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Eliminate-arbitrary-length-limit-on-labels.patch
Type: text/x-diff
Size: 2214 bytes
Desc: not available
URL: <https://lists.gnupg.org/pipermail/gnupg-devel/attachments/20180522/291fb120/attachment-0001.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Unescape-description-texts.patch
Type: text/x-diff
Size: 2167 bytes
Desc: not available
URL: <https://lists.gnupg.org/pipermail/gnupg-devel/attachments/20180522/291fb120/attachment-0002.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: Digital signature
URL: <https://lists.gnupg.org/pipermail/gnupg-devel/attachments/20180522/291fb120/attachment.sig>


More information about the Gnupg-devel mailing list