[PATCH] efl: ensure pinentry window is activated

Bertrand Jacquin bertrand at jacquin.bzh
Sat Feb 13 17:09:38 CET 2021


This ensure the new window displayed on screen is grabbed/focused and
PIN is entered in the newly created window rather than shell or
application with active focus which can lead to accidental PIN leak.
---
 efl/pinentry-efl.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/efl/pinentry-efl.c b/efl/pinentry-efl.c
index f1fb8b8149f8..2231b70a5c9e 100644
--- a/efl/pinentry-efl.c
+++ b/efl/pinentry-efl.c
@@ -542,11 +542,13 @@ create_window (void)
   evas_object_show (obj);
 
   elm_win_resize_object_add(win,obj);
-  evas_object_show(win);
 
   if(entry)
     elm_object_focus_set (entry, EINA_TRUE);
 
+  evas_object_show(win);
+  elm_win_activate(win);
+
   if (pinentry->timeout > 0)
     timer = ecore_timer_add (pinentry->timeout,
                              (Ecore_Task_Cb)timeout_cb,



More information about the Gnupg-devel mailing list