[PATCH gnupg] dirmngr: Interrogate LDAP server when base DN specified

NIIBE Yutaka gniibe at fsij.org
Tue Sep 27 03:54:07 CEST 2022


Joey Berkovitz wrote:
> Patch attached, related to https://dev.gnupg.org/T6047

I tried to apply your patch, but I found questionable parts in your
patch.  So, to proceed, firstly, I pushed a change of factoring to
interrogate_ldap_dn function (993820c31521).

Questionable parts for me are:

* ldap_count_entries is a function name.  I don't understand "if"
  statement evaluating ldap_count_entries.

* IIUC, with user specified base DN, it may introduce a memory leak for
  basedn.

Fixing those things, I think that changes needed will be something like
the patch attached.

Could you test if it works well?
-- 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gnupg-T6047.patch
Type: text/x-diff
Size: 2674 bytes
Desc: not available
URL: <https://lists.gnupg.org/pipermail/gnupg-devel/attachments/20220927/97ce901f/attachment.patch>


More information about the Gnupg-devel mailing list