Drop 'unknown' suffix in runtime version

[Alan Coopersmith]

On 5/19/25 08:06, Ingo Klöcker wrote:
> On Sonntag, 18. Mai 2025 10:57:33 Mitteleuropäische Sommerzeit Yi Zhao via
> Gnupg-devel wrote:
>> When I build gunpg in Yocto, a "-unknown" suffix appears in the gpg
>> runtime version:
>>
>> $ gpg --version
>> gpg (GnuPG) 2.5.5-unknown
>>
>> This is because the configure will be re-generated by autoreconf in
>> Yocto. The autogen.sh will add "-unknown" suffix to PACKAGE_VERSION.
>> Now I have a simple patch to remove this suffix in autogen.sh.
>> I wonder if there is a more appropriate way to resolve this? Thanks.
> 
> Some Linux distributions have similar patches to remove this suffix because for
> some reason or other they also regenerate the configure script. Since the Linux
> distributions also apply other patches it's actually not nice that they remove
> the suffix because they clearly don't ship the version that their packages
> announce. If they don't like the "-unknown" suffix then they should append a
> suffix like "-DISTRONAME" so that everybody knows that they don't use the
> released version as-is.

I use the patch from Debian in our builds for Solaris:
https://github.com/oracle/solaris-userland/blob/master/components/gnupg/patches/002-avoid-beta-warning.patch

because we apply a patch that only affects the configure script, not the
built binaries, to make it work correctly with gcc 14:
https://github.com/oracle/solaris-userland/blob/master/components/gnupg/patches/001-gcc-14.patch

Fortunately, this has been fixed in later versions so we should be able to
drop both patches when upgrading.

Since only changes that affect the configure script require this override,
it's not a good way to determine if distros have made changes to the source
code itself.

-- 
         -Alan Coopersmith-                 alan.coopersmith at oracle.com
          Oracle Solaris Engineering - https://blogs.oracle.com/solaris