<!DOCTYPE html>
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<div class="moz-cite-prefix">On 6/16/25 03:21, Sachin T via
Gnupg-devel wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CO1PR15MB5003C1ECA0048B0AA45464489770A@CO1PR15MB5003.namprd15.prod.outlook.com">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<meta name="Generator"
content="Microsoft Word 15 (filtered medium)">
<style>@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}@font-face
{font-family:Aptos;
panose-1:2 11 0 4 2 2 2 2 2 4;}p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
font-size:11.0pt;
font-family:"Aptos",sans-serif;}a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#467886;
text-decoration:underline;}p.MsoListParagraph, li.MsoListParagraph, div.MsoListParagraph
{mso-style-priority:34;
margin-top:0cm;
margin-right:0cm;
margin-bottom:0cm;
margin-left:36.0pt;
font-size:11.0pt;
font-family:"Aptos",sans-serif;}.MsoChpDefault
{mso-style-type:export-only;
font-size:11.0pt;
mso-ligatures:none;}div.WordSection1
{page:WordSection1;}ol
{margin-bottom:0cm;}ul
{margin-bottom:0cm;}</style>
<div class="WordSection1">
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">Hi,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">Please
review the updated patch with comments from Werner, Jacob
and Todd fixed.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">*Renamed
environ variable to avoid conflict with environ defined in
z/os stdlib header</span></p>
</div>
</blockquote>
<p>First, a nit: the renamed environ is a structure field, not a
variable. (I would have used "env" instead of "environ_p" but
that is just bikeshedding.)<br>
</p>
<p>Second, you are still adding $(LIBS) to the build rule for
mkheader and you should mention that as you previously did.</p>
<p>Lastly, I am probably more impressed than I should be that this
is all you actually need for a z/OS port. (The other system that
I know of where "environ" is a macro is not a POSIX system.)<br>
</p>
<blockquote type="cite"
cite="mid:CO1PR15MB5003C1ECA0048B0AA45464489770A@CO1PR15MB5003.namprd15.prod.outlook.com">
<div class="WordSection1">
<p class="MsoNormal"><span style="mso-fareast-language:EN-US"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">Regards<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">Sachin<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">---<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">Signed-off-by:
Sachin T
<a href="mailto:sachin.t@ibm.com" moz-do-not-send="true"
class="moz-txt-link-freetext">sachin.t@ibm.com</a><o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">---<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">src/Makefile.am
| 2 +-<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">src/spawn-posix.c
| 8 ++++----<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">2
files changed, 5 insertions(+), 5 deletions(-)<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">diff
--git a/src/Makefile.am b/src/Makefile.am<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">index
e56bb23..7e874cf 100644<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">---
a/src/Makefile.am<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">+++
b/src/Makefile.am<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">@@
-275,7 +275,7 @@ errnos-sym.h: Makefile mkstrtable.awk
errnos.in<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">mkheader$(EXEEXT_FOR_BUILD):
mkheader.c Makefile<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">
$(CC_FOR_BUILD) $(CFLAGS_FOR_BUILD) $(LDFLAGS_FOR_BUILD) \<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">-
$(CPPFLAGS_FOR_BUILD) -g -I. -I$(srcdir) -o $@
$(srcdir)/mkheader.c<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">+
$(CPPFLAGS_FOR_BUILD) -g -I. -I$(srcdir) -o $@
$(srcdir)/mkheader.c $(LIBS)<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">parts_of_gpg_error_h
= \<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">
gpg-error.h.in \<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">diff
--git a/src/spawn-posix.c b/src/spawn-posix.c<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">index
ac19761..0ffc71e 100644<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">---
a/src/spawn-posix.c<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">+++
b/src/spawn-posix.c<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">@@
-63,7 +63,7 @@<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">struct
gpgrt_spawn_actions {<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">
int fd[3];<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">
const int *except_fds;<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">-
char **environ;<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">+
char **environ_p;<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">
const char *const *envchange;<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">
void (*atfork) (void *);<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">
void *atfork_arg;<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">@@
-414,8 +414,8 @@ my_exec (const char *pgmname, const char
*argv[], gpgrt_spawn_actions_t act)<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">
if (pgmname == NULL)<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">
return 0;<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">-
if (act->environ)<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">-
execve (pgmname, (char *const *)argv, act->environ);<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">+
if (act->environ_p)<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">+
execve (pgmname, (char *const *)argv, act->environ_p);<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">
else<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">
execv (pgmname, (char *const *)argv);<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">@@
-516,7 +516,7 @@ void<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">_gpgrt_spawn_actions_set_environ
(gpgrt_spawn_actions_t act,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">
char **environ_for_child)<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">{<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">-
act->environ = environ_for_child;<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">+
act->environ_p = environ_for_child;<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">}<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">void<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">--<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">2.39.5
(Apple Git-154)</span></p>
</div>
</blockquote>
<p><br>
</p>
<p>-- Jacob</p>
</body>
</html>