<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Aptos;
panose-1:2 11 0 4 2 2 2 2 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
font-size:11.0pt;
font-family:"Aptos",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#467886;
text-decoration:underline;}
span.EmailStyle21
{mso-style-type:personal-reply;
font-family:"Aptos",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;
mso-ligatures:none;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style>
</head>
<body lang="EN-IN" link="#467886" vlink="purple" style="word-wrap:break-word">
<div class="WordSection1">
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">Thanks. I’ll update the patch description to mention the $(LIBS) change as well. I’ll also rename the struct field to env for clarity.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">And yes, z/OS is POSIX-compliant in general, but sometimes we run into small quirks like this environ macro.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">Regards<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">Sachin<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<div id="mail-editor-reference-message-container">
<div>
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal" style="margin-bottom:12.0pt"><b><span style="color:black">From:
</span></b><span style="color:black">Jacob Bachmeyer <jcb62281@gmail.com><br>
<b>Date: </b>Tuesday, 17 June 2025 at 7:33</span><span style="font-family:"Arial",sans-serif;color:black"> </span><span style="color:black">AM<br>
<b>To: </b>Sachin T <sachin.t@ibm.com>, gnupg-devel@gnupg.org <gnupg-devel@gnupg.org><br>
<b>Subject: </b>[EXTERNAL] Re: [PATCH libgpg-error] Add support for IBM z/OS</span><span style="font-size:12.0pt;color:black"><o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:.75pt"><span style="font-size:1.0pt;color:white">On 6/16/25 03:</span><span style="font-size:1.0pt;font-family:"Arial",sans-serif;color:white"> </span><span style="font-size:1.0pt;color:white">21, Sachin T via
Gnupg-devel wrote: Hi, Please review the updated patch with comments from Werner, Jacob and Todd fixed. *Renamed environ variable to avoid conflict with environ defined in z/os stdlib header First, a nit:</span><span style="font-size:1.0pt;font-family:"Arial",sans-serif;color:white"> </span><span style="font-size:1.0pt;color:white"> <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:.75pt"><span style="font-size:1.0pt;color:white"><o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal">On 6/16/25 03:21, Sachin T via Gnupg-devel wrote:<span style="font-size:12.0pt"><o:p></o:p></span></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<div>
<p class="MsoNormal">Hi,<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">Please review the updated patch with comments from Werner, Jacob and Todd fixed.<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">*Renamed environ variable to avoid conflict with environ defined in z/os stdlib header<o:p></o:p></p>
</div>
</blockquote>
<p>First, a nit: the renamed environ is a structure field, not a variable. (I would have used "env" instead of "environ_p" but that is just bikeshedding.)<o:p></o:p></p>
<p>Second, you are still adding $(LIBS) to the build rule for mkheader and you should mention that as you previously did.<o:p></o:p></p>
<p>Lastly, I am probably more impressed than I should be that this is all you actually need for a z/OS port. (The other system that I know of where "environ" is a macro is not a POSIX system.)<o:p></o:p></p>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<div>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">Regards<o:p></o:p></p>
<p class="MsoNormal">Sachin<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">---<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">Signed-off-by: Sachin T <a href="mailto:sachin.t@ibm.com">sachin.t@ibm.com</a><o:p></o:p></p>
<p class="MsoNormal">---<o:p></o:p></p>
<p class="MsoNormal">src/Makefile.am | 2 +-<o:p></o:p></p>
<p class="MsoNormal">src/spawn-posix.c | 8 ++++----<o:p></o:p></p>
<p class="MsoNormal">2 files changed, 5 insertions(+), 5 deletions(-)<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">diff --git a/src/Makefile.am b/src/Makefile.am<o:p></o:p></p>
<p class="MsoNormal">index e56bb23..7e874cf 100644<o:p></o:p></p>
<p class="MsoNormal">--- a/src/Makefile.am<o:p></o:p></p>
<p class="MsoNormal">+++ b/src/Makefile.am<o:p></o:p></p>
<p class="MsoNormal">@@ -275,7 +275,7 @@ errnos-sym.h: Makefile mkstrtable.awk errnos.in<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">mkheader$(EXEEXT_FOR_BUILD): mkheader.c Makefile<o:p></o:p></p>
<p class="MsoNormal"> $(CC_FOR_BUILD) $(CFLAGS_FOR_BUILD) $(LDFLAGS_FOR_BUILD) \<o:p></o:p></p>
<p class="MsoNormal">- $(CPPFLAGS_FOR_BUILD) -g -I. -I$(srcdir) -o $@ $(srcdir)/mkheader.c<o:p></o:p></p>
<p class="MsoNormal">+ $(CPPFLAGS_FOR_BUILD) -g -I. -I$(srcdir) -o $@ $(srcdir)/mkheader.c $(LIBS)<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">parts_of_gpg_error_h = \<o:p></o:p></p>
<p class="MsoNormal"> gpg-error.h.in \<o:p></o:p></p>
<p class="MsoNormal">diff --git a/src/spawn-posix.c b/src/spawn-posix.c<o:p></o:p></p>
<p class="MsoNormal">index ac19761..0ffc71e 100644<o:p></o:p></p>
<p class="MsoNormal">--- a/src/spawn-posix.c<o:p></o:p></p>
<p class="MsoNormal">+++ b/src/spawn-posix.c<o:p></o:p></p>
<p class="MsoNormal">@@ -63,7 +63,7 @@<o:p></o:p></p>
<p class="MsoNormal">struct gpgrt_spawn_actions {<o:p></o:p></p>
<p class="MsoNormal"> int fd[3];<o:p></o:p></p>
<p class="MsoNormal"> const int *except_fds;<o:p></o:p></p>
<p class="MsoNormal">- char **environ;<o:p></o:p></p>
<p class="MsoNormal">+ char **environ_p;<o:p></o:p></p>
<p class="MsoNormal"> const char *const *envchange;<o:p></o:p></p>
<p class="MsoNormal"> void (*atfork) (void *);<o:p></o:p></p>
<p class="MsoNormal"> void *atfork_arg;<o:p></o:p></p>
<p class="MsoNormal">@@ -414,8 +414,8 @@ my_exec (const char *pgmname, const char *argv[], gpgrt_spawn_actions_t act)<o:p></o:p></p>
<p class="MsoNormal"> if (pgmname == NULL)<o:p></o:p></p>
<p class="MsoNormal"> return 0;<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">- if (act->environ)<o:p></o:p></p>
<p class="MsoNormal">- execve (pgmname, (char *const *)argv, act->environ);<o:p></o:p></p>
<p class="MsoNormal">+ if (act->environ_p)<o:p></o:p></p>
<p class="MsoNormal">+ execve (pgmname, (char *const *)argv, act->environ_p);<o:p></o:p></p>
<p class="MsoNormal"> else<o:p></o:p></p>
<p class="MsoNormal"> execv (pgmname, (char *const *)argv);<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">@@ -516,7 +516,7 @@ void<o:p></o:p></p>
<p class="MsoNormal">_gpgrt_spawn_actions_set_environ (gpgrt_spawn_actions_t act,<o:p></o:p></p>
<p class="MsoNormal"> char **environ_for_child)<o:p></o:p></p>
<p class="MsoNormal">{<o:p></o:p></p>
<p class="MsoNormal">- act->environ = environ_for_child;<o:p></o:p></p>
<p class="MsoNormal">+ act->environ_p = environ_for_child;<o:p></o:p></p>
<p class="MsoNormal">}<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">void<o:p></o:p></p>
<p class="MsoNormal">--<o:p></o:p></p>
<p class="MsoNormal">2.39.5 (Apple Git-154)<o:p></o:p></p>
</div>
</blockquote>
<p><o:p> </o:p></p>
<p>-- Jacob<o:p></o:p></p>
</div>
</div>
</div>
</div>
</body>
</html>