Bug or Feature in rndw32.c ?

[Kiefer, Sascha]

I just had a look on the source to get an idee of gathering entropy.
I noticed the following:

Line 660-664:

(*add) ( &minimumWorkingSetSize,
		   sizeof (&minimumWorkingSetSize), requester );
(*add) ( &maximumWorkingSetSize,
		   sizeof (&maximumWorkingSetSize), requester );


Of course, on a 32-bit maschine, the size of a ptr is 4 which is the same as
the size of a DWORD but i think you meant

(*add) ( &minimumWorkingSetSize,
		   sizeof (minimumWorkingSetSize), requester );
(*add) ( &maximumWorkingSetSize,
		   sizeof (maximumWorkingSetSize), requester );

here.


Line 691:
(*add) (&performanceCount, sizeof (&performanceCount), requester);

Here you just add LowPart of the LARGE_INTEGER (which makes sense since it
changes the most)
but then I would prefer

(*add) (&performanceCount.LowPart, sizeof (performanceCount.LowPart),
requester);


HTH
esskar