GnuPG 2.0.10 - t-convert test fails on ppc and s390

Petr Uzel petr.uzel at suse.cz
Mon Jan 19 15:42:21 CET 2009


On Mon, Jan 19, 2009 at 02:00:43PM +0100, Werner Koch wrote:
> Hi,
> 
> Can you please test this patch:
> 
> 2009-01-19  Werner Koch  <wk at g10code.com>
> 
> 	* convert.c (hex2str): Fix optimization to append a nul character.
> 
> Index: common/convert.c
> ===================================================================
> --- common/convert.c    (revision 4915)
> +++ common/convert.c    (working copy)
> @@ -194,7 +194,9 @@
>      ;
>    if (*s && (!isascii (*s) || !isspace (*s)) )
>      return NULL;   /* Not followed by Nul or white space.  */
> -  need_nul = !(s[-2] == '0' && s[-1] == '0');
> +  /* We need to append a nul character.  However we don't want that if
> +     the hexstring already ends with "00".  */
> +  need_nul = ((s == hexstring) || !(s[-2] == '0' && s[-1] == '0'));
>    if (need_nul)
>      count++;

Thanks, this made make check happy.

-- 
Best regards / s pozdravem

Petr Uzel, Packages maintainer
---------------------------------------------------------------------
SUSE LINUX, s.r.o.                          e-mail: puzel at suse.cz
Lihovarská 1060/12                          tel: +420 284 028 964
190 00 Prague 9                             fax: +420 284 028 951
Czech Republic                              http://www.suse.cz



More information about the Gnupg-users mailing list