[PATCH] Fix bug in GnuK PIN pad support.

perillamint perillamint at gentoo.moe
Sat Nov 28 23:47:41 CET 2015


I found a bug (maybe a typo?) while playing with GnuK PIN pad support.

In openpgp.c L1410, it fills with bConfirmPIN with apdu.cmd_apdu_data[5].

It does not work when I gave it bPinSupport = 3 - which allows PIN
modification via PIN pad.

While I searching for solution, I found usb-icc.c mentions bConfirmPIN
is located in cmd_apdu_data[0]. I fixed openpgp.c to use [0] and it
seems to work well.

I attached patch for this.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-offset-of-bConfirmPIN.patch
Type: text/x-patch
Size: 740 bytes
Desc: not available
URL: </pipermail/attachments/20151129/61d179c2/attachment.bin>

More information about the Gnupg-users mailing list