[gnutls-dev] Fixing OpenPGP keyring import

[Ludovic Courtès]

Hi!

Simon Josefsson <simon at josefsson.org> writes:

> If the current code never worked, your patch is an improvement,
> though.

Yeah, probably worth installing.

>> Fixing this would require one of the following:
>>
>>   1. fixing `cdk_keydb_new ()' so that one can pass an additional
>>      argument indicating the format.
>>
>>   2. providing a new function, say `cdk_keydb_from_stream ()', where one
>>      can pass an arbitrary stream as the keyring source.
>>
>> Solution (2) seems more flexible and cleaner.  One could pass
>> `cdk_keydb_from_stream ()' a stream with or without the armor flag set,
>> thereby fixing our problem.  It would also have the advantage of not
>> breaking OpenCDK's ABI.  `cdk_keydb_new ()' could then be rewritten in
>> terms of it.
>
> Yeah, I'd go with 2) or
>
> 3) Create cdk_keydb_new_base64 that works like cdk_keydb_new but takes
> a text keydb.

I'd be more in favor of (2) (looks more consistent IMO).

> Timo's recent work break the API/ABI though, so I'm not sure how soon
> GnuTLS will start to use the new OpenCDK APIs, or how the migration
> will happen.  We'll probably should discuss that here.

Then, should we consider the transition to be a long-term goal and hack
our own version of OpenCDK in the meantime?  Or should we just switch
ASAP, if at all possible?

Thanks,
Ludovic.