[PATCH] add DN import function

Nikos Mavrogiannopoulos nmav at gnutls.org
Tue Feb 19 21:26:40 CET 2008


Joe Orton wrote:
> On Sat, Feb 16, 2008 at 11:25:38AM +0200, Nikos Mavrogiannopoulos wrote:
>> On Thursday 14 February 2008, Joe Orton wrote:
>>> The CA dnames passed to the client-cert-retrieve function are raw DER
>>> and hence can't be used by gnutls_x509_dn_get_rdn_ava().
>>>
>>> This patch adds gnutls_x509_dn_import() which fills that gap, and
>>> gnutls_x509_free_dn() which destroys the allocated structures.
>>>
>>> The naming is slightly awkward because these don't fit the usual
>>> init/import/deinit convention used by GnuTLS; let me know if you'd
>>> prefer different names.
>> This is a nice addition, thank you. About the nameing I think
>> gnutls_x509_free_dn should be better named gnutls_x509_dn_deinit to be more 
>> consistent with the other deinitialization functions. Would this be ok with 
>> you?
> 
> Sure, no problem.  Here's an updated patch:

Thank you Joe. I've just added the patch in the development branch. I've 
  also added gnutls_x509_dn_init function if this is ok with you.

The commitdiff is:
http://git.savannah.gnu.org/gitweb/?p=gnutls.git;a=commitdiff;h=9969955bec0da9ce2eff00504156223130e6cb9c

regards,
Nikos





More information about the Gnutls-devel mailing list