Minor fixes for gnutls 2.9.4

Fabian Keil fk at fabiankeil.de
Mon Aug 31 20:32:23 CEST 2009


Simon Josefsson <simon at josefsson.org> wrote:

> Fabian Keil <fk at fabiankeil.de> writes:
> 
> > The attached patches fix a few minor issues in
> > gnutls-20090829.tar.bz2, most of them pointed out by clang.
> 
> Thank you, I have applied them all except for 0005 which I decided to
> solve differently.

Great.

> > fk at r500 ~/git/gnutls/gnutls-2.9.4 $cat -n lib/opencdk/misc.c | grep
> > 12[34] 123    for (node = root->next; node; node = node->next)
> >    124      return node;
> >
> > and wonder if an if block wouldn't be more suitable here.
> 
> Or why not just 'return root->next'?

Indeed.

Fabian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
URL: </pipermail/attachments/20090831/5b906d95/attachment.pgp>


More information about the Gnutls-devel mailing list