Bug in gnutls breaking Pidgin Jabber support

[Simon Josefsson]

Tim Kosse <tim.kosse at filezilla-project.org> writes:

> Hi,
>
> since my initial assumptions got invalidated, I no longer consider my
> earlier patch as a merely an ugly workaround but instead as a viable
> solution. I've attached an updated version of the patch. In addition to
> _gnutls_io_write_buffered, _gnutls_handshake_io_send_int is fixed as well.
>
> Combined with the handshake patch I've previously mailed, I've been
> unable to reproduce any problems with GnuTLS in FileZilla.

How are those two patches related?  Is this patch for application data,
and the other for handshakes?  We need a NEWS entry for this.  I'm
considering:

** libgnutls: Avoid internal error when invoked after GNUTLS_E_AGAIN.
Report and patch by Tim Kosse <tim.kosse at filezilla-project.org> in
<http://permalink.gmane.org/gmane.comp.encryption.gpg.gnutls.devel/3671>
and
<http://permalink.gmane.org/gmane.comp.encryption.gpg.gnutls.devel/3670>.

Or should the two patches have one NEWS entry each?  Please advice.

/Simon

> --- lib/gnutls_buffers.c_old	2009-06-29 09:57:46.934517539 +0200
> +++ lib/gnutls_buffers.c	2009-06-30 23:43:22.000000000 +0200
> @@ -657,7 +657,7 @@
>      {
>        gnutls_datum bdata;
>        /* checking is handled above */
> -      _gnutls_buffer_get_datum (&session->internals.record_send_buffer, &bdata, n);
> +      _gnutls_buffer_get_datum (&session->internals.record_send_buffer, &bdata, session->internals.record_send_buffer.length);
>  
>        ptr = bdata.data;
>        n = bdata.size;
> @@ -854,7 +854,7 @@
>        gnutls_assert ();
>  
>        /* checking is handled above */
> -      _gnutls_buffer_get_datum (&session->internals.handshake_send_buffer, &bdata, n);
> +      _gnutls_buffer_get_datum (&session->internals.handshake_send_buffer, &bdata, session->internals.handshake_send_buffer.length);
>  
>        ptr = bdata.data;
>        n = bdata.size;
> _______________________________________________
> Gnutls-devel mailing list
> Gnutls-devel at gnu.org
> http://lists.gnu.org/mailman/listinfo/gnutls-devel