Missing curly braces in rsa_params::operator= (gnutlsxx.cpp)?

[Jason Pettiss]

> We haven't used CVS in quite a while, please check
> instructions on how
> to retrieve sources from Git:
> 
> https://savannah.gnu.org/git/?group=gnutls

Oh thank goodness.  CVS gives me hives.  :)

> Btw, did you read that we used CVS somewhere?  I may
> have forgotten to
> update some old information.

http://josefsson.org/gnutls4win/

"First checkout the files in this directory as follows:

cvs -z3 -d:pserver:anonymous at cvs.savannah.gnu.org:/sources/gnutls co gnutls4win
"

There is a CVS server there, and the ViewCVS link does work... I followed that around to find the libraries I thought I needed.

--jason

--- On Fri, 10/23/09, Simon Josefsson <simon at josefsson.org> wrote:

> From: Simon Josefsson <simon at josefsson.org>
> Subject: Re: Missing curly braces in rsa_params::operator= (gnutlsxx.cpp)?
> To: "Jason Pettiss" <jpettiss at yahoo.com>
> Cc: bug-gnutls at gnu.org
> Date: Friday, October 23, 2009, 11:22 AM
> Jason Pettiss <jpettiss at yahoo.com>
> writes:
> 
> > I have version 2.8.4 of the source... tried to check
> the latest in the CVS repository but the CVS server itself
> seems to be out of disk space?
> 
> We haven't used CVS in quite a while, please check
> instructions on how
> to retrieve sources from Git:
> 
> https://savannah.gnu.org/git/?group=gnutls
> 
> Btw, did you read that we used CVS somewhere?  I may
> have forgotten to
> update some old information.
> 
> > Anyway it looks like the error check in
> rsa_params::operator= is missing a code block and will
> unconditionally throw.
> >
> > rsa_params & rsa_params::operator=(const
> rsa_params& src)
> > {
> >     rsa_params* dst = new
> rsa_params;
> >     int ret;
> >     ret = gnutls_rsa_params_cpy(
> dst->params, src.params);
> >     if (ret < 0)
> >         delete dst;
> >     throw(ret);
> >     return *dst;
> > }
> >
> > Probably should have been:
> >
> >     if (ret < 0) {
> >         delete dst;
> >         throw(ret);
> 
> Heh.  Fixed, thank you.
> 
> /Simon
>