gnutls 2.11.1

[Ludovic Courtès]

Hi Nikos,

Nikos Mavrogiannopoulos <nmav at gnutls.org> writes:

> On 09/18/2010 11:35 PM, Ludovic Courtès wrote:
>
>> --8<---------------cut here---------------start------------->8---
>> Program received signal SIGSEGV, Segmentation fault.
>> 0x00007ffff762956c in __gmpz_set () from /nix/store/00fbkpgn2g1xrp39crrvnyjb2kj3m6js-gmp-4.3.2/lib/libgmp.so.3
>> (gdb) bt
>> #0  0x00007ffff762956c in __gmpz_set () from /nix/store/00fbkpgn2g1xrp39crrvnyjb2kj3m6js-gmp-4.3.2/lib/libgmp.so.3
>> #1  0x00007ffff76230dd in __gmpz_invert () from /nix/store/00fbkpgn2g1xrp39crrvnyjb2kj3m6js-gmp-4.3.2/lib/libgmp.so.3
>> #2  0x00007ffff5bbda41 in wrap_nettle_pk_fixup (algo=<value optimized out>, direction=<value optimized out>, params=0x7fffffffc200) at pk.c:564
>> #3  0x00007ffff5ba05ea in _gnutls_pk_fixup (pkey=<value optimized out>, keyid=<value optimized out>, params=0x7fffffffc2d0, params_size=0x7fffffffc36c) at ../gnutls_pk.h:42
>> #4  _gnutls_openpgp_privkey_get_mpis (pkey=<value optimized out>, keyid=<value optimized out>, params=0x7fffffffc2d0, params_size=0x7fffffffc36c) at privkey.c:765
>> #5  0x00007ffff5ba37c9 in gnutls_openpgp_privkey_sign_hash (key=0x6666f0, hash=0x7fffffffc4c0, signature=0x7fffffffc530) at gnutls_openpgp.c:885
>> #6  0x00007ffff5b56729 in _gnutls_handshake_sign_data (session=0x6754f0, cert=0x676430, pkey=0x669680, params=<value optimized out>, signature=0x7fffffffc530, sign_algo=<value optimized out>) at gnutls_sig.c:221
>> #7  0x00007ffff5b579be in gen_dhe_server_kx (session=0x6754f0, data=0x7fffffffc5a8) at auth_dhe.c:151
>> #8  0x00007ffff5b44a8e in _gnutls_send_server_kx_message (session=0x6754f0, again=<value optimized out>) at gnutls_kx.c:180
>> #9  0x00007ffff5b41f1f in _gnutls_handshake_server (session=0x6754f0) at gnutls_handshake.c:2971
>> #10 0x00007ffff5b4253d in gnutls_handshake (session=0x6754f0) at gnutls_handshake.c:2634
>> #11 0x00007ffff5e191c2 in scm_gnutls_handshake (session=<value optimized out>) at core.c:161
>> #12 0x00007ffff7b3ef98 in vm_debug_engine (vm=0x6bc370, program=0x1, argv=0x6be320, nargs=0) at vm-i-system.c:860
>> #13 0x00007ffff7b3ef98 in vm_debug_engine (vm=0x6bc370, program=0x1, argv=0x6be260, nargs=0) at vm-i-system.c:860
>> #14 0x00007ffff7ac8fa3 in scm_primitive_eval (exp=0x95c6e0) at eval.c:844
>> #15 0x00007ffff7ac9003 in scm_eval (exp=0x95c6e0, module_or_state=0x6bd090) at eval.c:878
>> #16 0x00007ffff7b0d3af in scm_shell (argc=2, argv=0x7fffffffcca8) at script.c:760
>> #17 0x00007ffff7ae0ecf in invoke_main_func (body_data=<value optimized out>) at init.c:383
>> #18 0x00007ffff7abfb2a in c_body (d=0x7fffffffcad0) at continuations.c:473
>> #19 0x00007ffff7b3ed1b in vm_debug_engine (vm=0x6bc370, program=0x8e3520, argv=0x6be0b8, nargs=1) at vm-i-system.c:928
>> #20 0x00007ffff7ac8e63 in scm_call_4 (proc=0x659090, arg1=<value optimized out>, arg2=<value optimized out>, arg3=<value optimized out>, arg4=<value optimized out>) at eval.c:582
>> #21 0x00007ffff7ac0173 in scm_i_with_continuation_barrier (body=0x7ffff7abfb20 <c_body>, body_data=0x7fffffffcad0, handler=0x7ffff7abfb40 <c_handler>, handler_data=0x7fffffffcad0, 
>>     pre_unwind_handler=<value optimized out>, pre_unwind_handler_data=<value optimized out>) at continuations.c:450
>> #22 0x00007ffff7ac0210 in scm_c_with_continuation_barrier (func=<value optimized out>, data=<value optimized out>) at continuations.c:491
>> #23 0x00007ffff7b30822 in scm_i_with_guile_and_parent (func=0x7ffff7ae0eb0 <invoke_main_func>, data=0x7fffffffcba0, parent=<value optimized out>) at threads.c:741
>> #24 0x00007ffff7ae0f85 in scm_boot_guile (argc=<value optimized out>, argv=<value optimized out>, main_func=<value optimized out>, closure=<value optimized out>) at init.c:366
>> #25 0x0000000000400c70 in main (argc=<value optimized out>, argv=<value optimized out>) at guile.c:70
>> (gdb) frame 5
>> #5  0x00007ffff5ba37c9 in gnutls_openpgp_privkey_sign_hash (key=0x6666f0, hash=0x7fffffffc4c0, signature=0x7fffffffc530) at gnutls_openpgp.c:885
>> 885           result = _gnutls_openpgp_privkey_get_mpis (key, NULL,
>> (gdb) p *key
>> $1 = {knode = 0x6670d0, preferred_keyid = "\000\000\000\000\000\000\000", preferred_set = 0}
>> (gdb) p *key->knode
>> $2 = {next = 0x6671d0, pkt = 0x679780, is_deleted = 0, is_cloned = 0}
>> --8<---------------cut here---------------end--------------->8---
>> 
>> This Guile test is the only unit test for OpenPGP authentication in
>> GnuTLS, and I feel that the issue is more closely related to the
>> CDK/Nettle integration than to Guile.
>> 
>
> Thank you! I've found the bug and commited a fix.

Great!

BTW, the test written in Scheme is almost twice as small as the one in C
and requires very little Scheme knowledge (hint, hint ;-)).

Thanks,
Ludo’.