[libvirt] failure to build on rawhide

[Daniel Veillard]

On Tue, May 03, 2011 at 05:33:11PM -0600, Eric Blake wrote:
> I'm getting this when trying to build libvirt on rawhide (using the
> package gnutls-devel-2.12.3-1.fc16.x86_64):
> 
> remote/remote_driver.c: In function 'negotiate_gnutls_on_connection':
> remote/remote_driver.c:1361:9: error:
> 'gnutls_certificate_type_set_priority' is deprecated (declared at
> /usr/include/gnutls/compat.h:347) [-Werror=deprecated-declarations]

  Since we don't normally build with -werror we should not need to
fix this for 0.9.1

> but I can't find anything in the gnutls man pages that says why it is
> deprecated or what to use in its place.  Any ideas?

Curl seems to have hit the same, and suggest to use
gnutls_priority_set_direct():

  http://curl.haxx.se/mail/lib-2011-04/0162.html

But the 2 functions are completely different, however at
  http://hackipedia.org/Software/GNU/gnutls/gnutls%20-%20Transport%20Layer%20Security%20Library%20for%20the%20GNU%20system%20v2.8.5%20%282%20June%202009%29.pdf.raw-conversion.utf-8.txt

  there are examples of the use of that function, taking a description
string instead of a list of parameters

    gnutls_priority_set_direct (session, "PERFORMANCE:!ARCFOUR-128", NULL);
    ...
    gnutls_priority_set_direct (session, "NORMAL:+SRP:+SRP-DSS:+SRP-RSA", NULL);
    ...
    const char *err;
    ret = gnutls_priority_set_direct (session, "PERFORMANCE", &err);

  Seems that instead of building a list of int, one need to build a
  string, and there is a better error reporting mechanism.


The main problem though is that we are gonna have to detect it in configure
because the replacement function gnutls_priority_set_direct is not
present in older release like gnutls-1.4.1 used to compile on RHEL-5 for
example.

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel at veillard.com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/