[sr #107860] The read_file function is too generic, clashes with similarly named functions in user applications

[Martin Storsjö]

URL:
  <http://savannah.gnu.org/support/?107860>

                 Summary: The read_file function is too generic, clashes with
similarly named functions in user applications
                 Project: GnuTLS
            Submitted by: mstorsjo
            Submitted on: Mon 31 Oct 2011 03:24:38 PM GMT
                Category: Core library
                Priority: 5 - Normal
                Severity: 2 - Minor
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
        Operating System: GNU/Linux

    _______________________________________________________

Details:

The read_file function is a very generic name, which can cause clashes with
functions named similarly in calling applications, if linking gnutls
statically. (One concrete case was in the ffmpeg/avconv applications, where
the function has been renamed as a preparation for adding gnutls support:
http://git.libav.org/?p=libav.git;a=commitdiff;h=02170990fdb2a05c6eaf5fd449f440ec51c0f822)

The attached patch renames this function and the other ones in gl/read-file.h,
by adding a leading underscore. Any other prefix that would be internal to
gnutls would work just as well.



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Mon 31 Oct 2011 03:24:38 PM GMT  Name:
0001-Rename-the-read_file-function-family.patch  Size: 11kB   By: mstorsjo

<http://savannah.gnu.org/support/download.php?file_id=24255>

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/support/?107860>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/