[gnutls-devel] [PATCH 3/4] tests: nist-pkits: cleanup shell/perl usage
alon.barlev at gmail.com
Fri Jun 19 06:02:55 CEST 2015
On 18 June 2015 at 14:25, Nikos Mavrogiannopoulos <nmav at gnutls.org> wrote:
> On Thu, Jun 18, 2015 at 11:05 AM, Alon Bar-Lev <alon.barlev at gmail.com> wrote:
> > On 18 June 2015 at 11:57, Nikos Mavrogiannopoulos <nmav at gnutls.org> wrote:
> >> Thanks. I've applied all except for this one. In that case
> >> "#!/usr/bin/perl" part is not needed. It is handled by the eval part
> >> which will detect perl even if in a different path.
> > This is ugly! :)
> > consider #!/usr/bin/env perl ?
> > or better, I can add autoconf detection for perl.
> Very ugly. I don't even remember why it was added. The problem it
> solved was supposedly to detect perl in all systems, by avoiding hard
> coded paths, but I'm not sure whether that was a real problem. If you
> have a better solution I'm certainly interested.
At least add #!/bin/sh in this case for now?
> > or convert this script to shell? it is not using much of perl
> > anyway... just executing shell over and over.
> There many other scripts in perl, so it wouldn't make much sense.
More information about the Gnutls-devel