[gnutls-devel] memmem missing when trying to compile gnutls 3.5.2 on Solaris

[Nikos Mavrogiannopoulos]

On Mon, 2016-07-11 at 14:28 +0200, Dagobert Michelsen wrote:
> ld: fatal: symbol referencing errors. No output written to
> > > resume-
> > > x509
> > > collect2: error: ld returned 1 exit status
> > > I suggest to import memmem from gnulib if necessary.
> > Memmem() is included in gnutls via gnulib (in gl/ directory) and
> > should
> > be used in systems that don't have it. Could you check in your logs
> > why
> > it is not used?
> I think this is missing:
> dam at unstable10s
> > [unstable10s]:/home/dam/mgar/pkg/gnutls3/trunk/work/solaris10-
> > sparc/build-isa-sparcv8plus/gnutls-3.5.2/tests > git diff --no-
> > color Makefile.am
> > diff --git a/tests/Makefile.am b/tests/Makefile.am
> > index e1f365f..0be380f 100644
> > --- a/tests/Makefile.am
> > +++ b/tests/Makefile.am
> > @@ -53,6 +53,7 @@ AM_CPPFLAGS = \
> >  AM_LDFLAGS = -no-install
> >  LDADD = ../lib/libgnutls.la \
> >         libutils.la \
> > +       ../gl/libgnu.la \
> >         $(LIBSOCKET) $(INET_NTOP_LIB) $(INET_PTON_LIB) 

I wanted to avoid introducing the gnulib dependency to all tests as it
often caused problems. I've solved it slightly different:

https://gitlab.com/gnutls/gnutls/commit/ec639d66325db855b91d41c969b753629fea9430

regards,
Nikos