[gnutls-devel] [PATCH] Broke apart _gnutls_recv_int() to the packet and non-packet cases.
nmav at gnutls.org
Mon Mar 21 12:04:15 CET 2016
On Mon, Mar 21, 2016 at 11:41 AM, Jaak Ristioja <jaak.ristioja at cyber.ee> wrote:
> Postponed, rejected or forgotten?
> On 15.02.2016 12:14, Jaak Ristioja wrote:
>> Only gnutls_record_recv_packet() called _gnutls_recv_int() with
>> (packet != NULL). I refactored this logic directly downstream into
>> gnutls_record_recv_packet(). The _gnutls_recv_int() function now only
>> handles non-packet specific logic. The _gnutls_recv_int2() function
>> was created to deduplicate common code which would otherwise have
>> ended up in both functions.
>> The rationale behind this change is to optimize what were previously
>> calls of _gnutls_recv_int(). First of all _gnutls_recv_int() now has
>> only 6 parameters, which according to the x86_64 System V Application
>> Binary Interface should now fit into CPU registers and no longer use
>> the stack. Secondly this change avoids a number of branching checks
>> for both packet and non-packet cases.
Must have lost it. I've now committed it with some minor tweaks
(function name changes).
More information about the Gnutls-devel