[gnutls-devel] [PATCH] tests: skip tests that requires tools if tools are disabled

[Alon Bar-Lev]

On 3 January 2017 at 09:22, Nikos Mavrogiannopoulos
<n.mavrogiannopoulos at gmail.com> wrote:
>
> What I am afraid of such a patch is having a test being skipped when
> it shouldn't. For which platform do you need this patch? Can it be
> worked around by not installing the tools instead?

Hi,

I considered several alternatives...

1. Force --enable-tools if --enable-tests in autoconf

We skip important tests that can be done for minimal installation.

2. Always build tools but modify automake to conditionally install
them based on --enable-tools

We have this huge dependency graph of autogen, guile and libxml with
their own dependencies.

3. Skip tests that requires tools

Test whatever we can without introducing more dependencies for minimal
installation.

4. Clone at least certtool which is common to all tests to
certtool-test that has no extra dependencies with simpler usage.

I chose #3 as it seems to balance between having minimal build with
minimal tests and full build and test suites.
However, #4 is the best but more than I can contribute right now.

I do not see that tests that are being skipped when explicit disabling
an option suggests that they should not be skipped... :)

Recently, in Gentoo we removed the --enable-tools by default, but
people expects that tests will succeed while these currently fails.
Maintainers will continue to run tests with tools enabled.

Regards,
Alon