[gnutls-devel] [PATCH] tests: skip tests that requires tools if tools are disabled

[Alon Bar-Lev]

Hi Nikos,

Will these patches be able to make it to 3.5 branch?
Will it help if I rebase?

Thanks,
Alon

https://gitlab.com/gnutls/gnutls/commit/276a6ee44d80d4d3b144a78794020c177be8f0ea
https://gitlab.com/gnutls/gnutls/commit/9f75df64d3a53e1cbad3eabf266acec7b426869a
https://gitlab.com/gnutls/gnutls/commit/9a38264f2065ae97ef3307f47c67bbee2313cb1c
https://gitlab.com/gnutls/gnutls/commit/98e49e9d0727d93a58b336dac0a78ce74558e8c8
https://gitlab.com/gnutls/gnutls/commit/41da7be67e0e0f30ea274a6f2d5af700be064b61
https://gitlab.com/gnutls/gnutls/commit/22da6ba5d5d719b125f28718861ad136fa7207af


On 3 January 2017 at 17:41, Alon Bar-Lev <alon.barlev at gmail.com> wrote:
>
> On 3 January 2017 at 10:51, Nikos Mavrogiannopoulos
> <n.mavrogiannopoulos at gmail.com> wrote:
> >
> > On Tue, Jan 3, 2017 at 8:51 AM, Alon Bar-Lev <alon.barlev at gmail.com> wrote:
> > > I considered several alternatives...
> > >
> > > 1. Force --enable-tools if --enable-tests in autoconf
> > >
> > > We skip important tests that can be done for minimal installation.
> > >
> > > 2. Always build tools but modify automake to conditionally install
> > > them based on --enable-tools
> > >
> > > We have this huge dependency graph of autogen, guile and libxml with
> > > their own dependencies.
> > >
> > > 3. Skip tests that requires tools
> > >
> > > Test whatever we can without introducing more dependencies for minimal
> > > installation.
> > >
> > > 4. Clone at least certtool which is common to all tests to
> > > certtool-test that has no extra dependencies with simpler usage.
> > >
> > > I chose #3 as it seems to balance between having minimal build with
> > > minimal tests and full build and test suites.
> > > However, #4 is the best but more than I can contribute right now.
> >
> > Ok, let's test it. Would you like to submit it as a merge request in
> > gitlab? That will make it run through the CI and we can verify that no
> > test cases are skipped unintentionally.
> >
> > regards,
> > Nikos
>
> Done[1]
>
> [1] https://gitlab.com/gnutls/gnutls/merge_requests/216