[gnutls-devel] [PATCH] gnutls-cli won't work with ejabberd

[pitchum]

Le 08/07/2017 à 09:30, Nikos Mavrogiannopoulos a écrit :
> On Thu, Jul 6, 2017 at 4:31 PM, pitchum <pitchum at gramaton.org> wrote:
>> My patch fixes 2 different problems.
> 
> Thank you for the patch. I no longer remember the details of the protocol, but
> my question here would be why not wait for the <features> text?

That's what I tried at first but then it broke support for prosody.
Maybe I didn't implement it the right way. As I said, I'm not a C
programmer. Then I found the solution based on usleep() and I was happy
because it introduces very few changes in the code and it worked like a
charm with both prosody and ejabberd.
I'll try to find a better solution though.


>> I decided to modify the possible values for --starttls-proto option:
>> xmpp is replaced with xmpp-client or xmpp-server to avoid confusion.
> 
> We would have to keep 'xmpp' for backwards compatibility (most likely
> to the most common variant). The CANON_SERVICE() macro should be
> updated as well.

Oh, I didn't see this macro. Ok then I'll try to make it clear in the
man page that xmpp is an alias for xmpp-server.


> I'd really appreciate a merge request, ideally with a testsuite
> similarly to tests/starttls-smtp.sh and friends.

I'll do that. But it'll take some time, don't be impatient :)


-- 
pitchum