[gnutls-devel] GnuTLS | Remove trailing dot from hostname input (!709)

[Nikos Mavrogiannopoulos]

Nikos Mavrogiannopoulos started a new discussion on src/socket.c:

>  	if (inet_pton(AF_INET6, hostname, buf) == 1)
>  		return;
>  
> -	*p = 0;
> +	if (p > hostname && p[-1] == '.')
> +		p[-1] = 0; // remove trailing dot on FQDN
> +	else
> +		*p = 0;

On a second look that does handle only some cases. If the "hostname:service" form is used the final '.' is removed. Otherwise if only hostname+'.' is provided my understanding is that it will not be detected.

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/merge_requests/709#note_89080717
You're receiving this email because of your account on gitlab.com.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20180719/50133957/attachment-0001.html>