[gnutls-devel] GnuTLS | Backport testpkcs11 from master branch (!712)

Anderson Sasaki gitlab at mg.gitlab.com
Fri Jul 20 17:05:48 CEST 2018

New Merge Request !712


Project:Branches: ansasaki/gnutls:test_pkcs11 to gnutls/gnutls:gnutls_3_3_x
Author:    Anderson Sasaki

This backports testpkcs11.sh from master branch. Some tests were disabled due to the use of features not supported in 3.3.x versions. Namely the missing features are:

- ECC key generation without login
- "--load-pubkey" option
- "--test-sign" option
- Certificates do not inherit its ID from the private key

Previously, certificates were being marked as private objects (CKA_PRIVATE), depending on the PKCS#11 module default. This behaviour was changed to follow the master branch; now p11tool explicitly sets the GNUTLS_PKCS11_OBJ_FLAG_MARK_PRIVATE flag when creating a private key object and GNUTLS_PKCS11_OBJ_FLAG_MARK_NOT_PRIVATE when creating a certificate or public key object.

## Checklist
 * [x] Code modified for feature
 * [x] Test suite updated with functionality tests
 * [x] Test suite updated with negative tests
 * [ ] Documentation updated

## Reviewer's checklist:
 * [ ] Any issues marked for closing are addressed
 * [ ] There is a test suite reasonably covering new functionality or modifications
 * [ ] Function naming, parameters, return values, types, etc., are consistent and according to `CONTRIBUTION.md`
 * [ ] This feature/change has adequate documentation added
 * [ ] No obvious mistakes in the code

Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/merge_requests/712
You're receiving this email because of your account on gitlab.com.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20180720/b722d43c/attachment.html>

More information about the Gnutls-devel mailing list