[gnutls-devel] GnuTLS | tests: improved test suite (!719)

Development of GNU's TLS library gnutls-devel at lists.gnutls.org
Fri Jul 27 14:24:43 CEST 2018


Nikos Mavrogiannopoulos commented on a discussion on src/common.c:

>  			print_ecdh_info(session, "Ephemeral ");
>  	}
>  
> +	version = gnutls_protocol_get_version(session);
>  	tmp =
> -	    SU(gnutls_protocol_get_name
> -	       (gnutls_protocol_get_version(session)));
> +	    SU(gnutls_protocol_get_name(version));
>  	printf("- Version: %s\n", tmp);
>  
> -	tmp = SU(gnutls_kx_get_name(kx));
> -	printf("- Key Exchange: %s\n", tmp);
> +	if (version < GNUTLS_TLS1_3) {
> +		tmp = SU(gnutls_kx_get_name(kx));
> +		printf("- Key Exchange: %s\n", tmp);

Right. This API however returns values compatible with the TLS1.2 ones. That is it will make the key exchange look as similar to TLS1.2 as possible (will report DHE-RSA for example). That's why I removed it as the "description" value is better suited for TLS1.3 or later.

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/merge_requests/719#note_90784271
You're receiving this email because of your account on gitlab.com.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20180727/8a3f6448/attachment.html>


More information about the Gnutls-devel mailing list