[gnutls-devel] GnuTLS | tls1.3: server returns early on handshake when no cert is provided by client (!711)

[Development of GNU's TLS library]

Nikos Mavrogiannopoulos commented on a discussion on lib/tls13/finished.c:

>  
>  	hash_size = session->security_parameters.prf->output_size;
>  
> -	if (session->security_parameters.entity == GNUTLS_CLIENT)
> -		base_key = session->key.proto.tls13.hs_skey;
> -	else
> -		base_key = session->key.proto.tls13.hs_ckey;
> +	if (!session->internals.initial_negotiation_completed) {

It is similar, but different keys are assigned on each case:
```
if (!session->internals.initial_negotiation_completed) {
         if (session->security_parameters.entity == GNUTLS_CLIENT)
                 base_key = session->key.proto.tls13.hs_ckey; <----

```

vs.
```
if (!session->internals.initial_negotiation_completed) {
        if (session->security_parameters.entity == GNUTLS_CLIENT)
                base_key = session->key.proto.tls13.hs_skey; <----

```

Not sure if it can be abstracted easily.

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/merge_requests/711#note_90792582
You're receiving this email because of your account on gitlab.com.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20180727/a72817e0/attachment.html>