[gnutls-devel] GnuTLS | WIP: RFC7250 Raw public keys (!650)

[Development of GNU's TLS library]

Nikos Mavrogiannopoulos started a new discussion on lib/rawpubkey.c:

> +	/* TODO find out wat it does. now copied from x509 func. */
> +	if( cred->pin.cb )
> +	{
> +		gnutls_privkey_set_pin_function( privkey, cred->pin.cb, cred->pin.data );
> +	}
> +
> +	/* Import x509 private key into our generic private key struct */
> +	ret = gnutls_privkey_import_x509( privkey, key, GNUTLS_PRIVKEY_IMPORT_COPY );
> +	if( ret < 0 )
> +	{
> +		gnutls_assert();
> +		return ret;
> +	}
> +
> +	/* We now convert our raw public key to a parsed certificate (pcert) structure */
> +	// Allocate some memory

nit: I think such comment is not necessary. The call to calloc is sufficient to indicate memory allocation is going on.

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/merge_requests/650#note_117469234
You're receiving this email because of your account on gitlab.com.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20181115/3a2a9167/attachment-0001.html>