[gnutls-devel] GnuTLS | gnutls_certificate_type_get*: ensure that the default type is returned (!806)

[Development of GNU's TLS library]

Nikos Mavrogiannopoulos commented on a discussion on lib/constate.c:

>  		dst->prf = src->prf; \
>  		dst->grp = src->grp; \
>  		dst->pversion = src->pversion; \
> +		dst->client_ctype = src->client_ctype; \

> > I understand. If I look at the packing code `session_pack.c` lines 913/914 I see that the cert types are only packed under TLS <1.3. Is this the desired behaviour or should we actually pack these params?

> It is also my understanding is that this will be sufficient, though I had no easy way to test it is functional.

Seeing however the tests I added, most likely they are sufficient as a basic functional test for X509. What do you think? Should I attempt fix it as part of the commit and the more elaborate tests with cert type changes are tested as part of the rfc7250 patches?

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/merge_requests/806#note_117503780
You're receiving this email because of your account on gitlab.com.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20181115/46e53389/attachment.html>