[gnutls-devel] GnuTLS | gnutls_priority_set: do not override version on handshake (!765)

[Development of GNU's TLS library]

Jakub Jelen started a new discussion on lib/handshake.c:

>  			return ret;
>  		}
>  
> -		vers = get_version(session);
> -		if (!vers->tls13_sem) {
> -			/* Here we need to renegotiate the version since the callee might
> -			 * have disabled some TLS versions. We only do it for TLS1.2 or
> -			 * earlier, as TLS1.3 uses a different set of ciphersuites, and
> -			 * thus we cannot fallback.
> -			 */
> -			ret = _gnutls_negotiate_version(session, major, minor, 0);
> -			if (ret < 0) {
> -				gnutls_assert();
> -				return ret;
> +		/* to catch any changes in the TLS protocol negotiation */
> +		if (session->internals.resumed != RESUME_TRUE) {

This line would deserve some comments why this does not apply for the session resumption.

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/merge_requests/765#note_106119649
You're receiving this email because of your account on gitlab.com.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20181003/9c69955e/attachment-0001.html>