[gnutls-devel] GnuTLS | gnutls_priority_set: do not override the version after handshake is complete (!777)

[Development of GNU's TLS library]

Tom started a new discussion on lib/priority.c:

>  	session->internals.priorities = priority;
>  	gnutls_atomic_increment(&priority->usage_cnt);
>  
> -	/* set the current version to the first in the chain.
> -	 * This will be overridden later.
> -	 */
> +	/* set the current version to the first in the chain, if that's
> +	 * the call before the initial handshake. This will be overridden by
> +	 * the handshake call. */

I don't understand what you mean with "This will be overridden by the handshake call."? Maybe you could comment this code like:
>  Set the current version to the first in the chain if this is the call before the initial handshake. During a rehandshake a potential new protocol version will be ignored.

Also, why not move the check at line 612 all the way up and return early?

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/merge_requests/777#note_110165118
You're receiving this email because of your account on gitlab.com.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20181019/9b96a48c/attachment-0001.html>