[gnutls-devel] GnuTLS | gnutls_priority_set: do not override the version after handshake is complete (!777)

Development of GNU's TLS library gnutls-devel at lists.gnutls.org
Tue Oct 23 20:06:27 CEST 2018

Tom commented on a discussion on lib/priority.c:

>  	session->internals.priorities = priority;
>  	gnutls_atomic_increment(&priority->usage_cnt);
> -	/* set the current version to the first in the chain.
> -	 * This will be overridden later.
> -	 */
> +	/* set the current version to the first in the chain, if that's
> +	 * the call before the initial handshake. This will be overridden by
> +	 * the handshake call. */

I would still move the if-statement at line 601 up (after line 587) to be able to return early. Also the condition at line 592 excludes the one at line 601. Don't you think that's better?

Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/merge_requests/777#note_111220066
You're receiving this email because of your account on gitlab.com.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20181023/7cf84164/attachment-0001.html>

More information about the Gnutls-devel mailing list