[gnutls-devel] GnuTLS | Session ticket key rotation with TOTP (!695)

[Development of GNU's TLS library]

Ander Juaristi commented on a discussion on lib/stek.c:

> +			mac_key->size = TICKET_MAC_SECRET_SIZE;
> +		}
> +		if (enc_key) {
> +			enc_key->data = &key.data[KEY_POS];
> +			enc_key->size = TICKET_CIPHER_KEY_SIZE;
> +		}
> +
> +		retval = GNUTLS_E_SUCCESS;
> +	} else {
> +		retval = GNUTLS_E_REQUESTED_DATA_NOT_AVAILABLE;
> +	}
> +
> +	return retval;
> +}
> +
> +int _gnutls_init_session_ticket_key(gnutls_session_t session,

I'm resolving this. I think it's better as it is now, putting that code outside of `stek.c` would break separation of concerns, and would pollute the session ticket code and make it harder to understand.

I've added a line to the docs of `_gnutls_initialize_session_ticket_key_rotation` however.

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/merge_requests/695#note_101696717
You're receiving this email because of your account on gitlab.com.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20180916/fb10e4a3/attachment.html>