[gnutls-devel] GnuTLS | crypto-api: add gnutls_aead_cipher_{en, de}crypt_vec (!1052)

[Development of GNU's TLS library]

Merge request https://gitlab.com/gnutls/gnutls/merge_requests/1052 was reviewed by Daiki Ueno

--
  
Daiki Ueno commented on a discussion on lib/iov.h: https://gitlab.com/gnutls/gnutls/merge_requests/1052#note_201548434

> +
> +		if (iter->block_offset > 0) {
> +			if ((size_t) len >= iter->block_size - iter->block_offset) {

Thanks, done.

--
  
Daiki Ueno commented on a discussion on lib/iov.h: https://gitlab.com/gnutls/gnutls/merge_requests/1052#note_201548443

> +		const giovec_t *iov = &iter->iov[iter->iov_index];
> +		uint8_t *p = iov->iov_base;
> +		ssize_t len = iov->iov_len;

This is a common convention throughout the code so the `DECR_LEN` macro work.

--
  
Daiki Ueno commented on a discussion on lib/iov.h: https://gitlab.com/gnutls/gnutls/merge_requests/1052#note_201548446

> +		}
> +
> +		memcpy(iter->block + iter->block_offset, p, len);

Nice, I've rewritten the blocks in a similar way.

--
  
Daiki Ueno commented on a discussion on lib/iov.h: https://gitlab.com/gnutls/gnutls/merge_requests/1052#note_201548450

> +
> +/* Initialize the iterator. */
> +static inline int

Moved to `iov.c`.


-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/merge_requests/1052
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20190808/66a5b608/attachment-0001.html>