[gnutls-devel] GnuTLS | crypto-api: add gnutls_aead_cipher_{en, de}crypt_vec (!1052)

[Development of GNU's TLS library]

Merge request https://gitlab.com/gnutls/gnutls/merge_requests/1052 was reviewed by Daiki Ueno

--
  
Daiki Ueno commented on a discussion on lib/iov.h: https://gitlab.com/gnutls/gnutls/merge_requests/1052#note_201866306

> +		const giovec_t *iov = &iter->iov[iter->iov_index];
> +		uint8_t *p = iov->iov_base;
> +		ssize_t len = iov->iov_len;

As `DECR_LEN` here works like an assertion, I just expanded it there.

--
  
Daiki Ueno commented on a discussion on lib/iov.h: https://gitlab.com/gnutls/gnutls/merge_requests/1052#note_201866308

> +		iter->iov_offset = 0;
> +	}
> +	return GNUTLS_E_REQUESTED_DATA_NOT_AVAILABLE;

OK, I changed the function to return the number of blocks in `data` and use 0 to indicate the EOF.

--
  
Daiki Ueno commented on a discussion on lib/iov.c: https://gitlab.com/gnutls/gnutls/merge_requests/1052#note_201866310

> + * Retrieve consecutive block(s) pointed by @iter and advance it to
> + * the next position.  At the end of iteration,
> + * %GNUTLS_E_REQUESTED_DATA_NOT_AVAILABLE is returned.

This is no longer applicable after making the function return the number of blocks.


-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/merge_requests/1052
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20190809/0e1d13b0/attachment.html>