[gnutls-devel] GnuTLS | Fix issues in record_size_limit extension handling (!879)

[Development of GNU's TLS library]

Hubert Kario started a new discussion on lib/ext/record_size_limit.c:

>  
> -	/* we do not want to accept sizes less than our minimum */
> -	if (new_size < MIN_RECORD_SIZE)
> -		return 0;
> +	session->internals.hsk_flags |= HSK_RECORD_SIZE_LIMIT_RECEIVED;
>  
> -	/* if a record size larger than user specified maximum, ignore it */
> -	if (new_size > session->security_parameters.max_record_send_size)
> -		return 0;
> +	/* we do not want to accept sizes outside of our supported range */
> +	if (new_size < MIN_RECORD_SIZE) {
> +		/* for server, reject it by omitting the extension in the reply */
> +		if (session->security_parameters.entity == GNUTLS_SERVER)
> +			return gnutls_assert_val(0);
> +		else
> +			return gnutls_assert_val(GNUTLS_E_RECEIVED_ILLEGAL_PARAMETER);

the server is not behaving incorrectly here, so at the very least, it feels to me like gnutls should log *why* it's rejecting it - I don't think the illegal_parameter is sufficient here

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/merge_requests/879#note_137509153
You're receiving this email because of your account on gitlab.com.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20190201/4cf88b94/attachment.html>