[gnutls-devel] GnuTLS | Bad assumption about sizeof long in src/serv-args.c (#700)

Development of GNU's TLS library gnutls-devel at lists.gnutls.org
Sun Feb 10 18:37:11 CET 2019

New Issue was created.

Issue 700: https://gitlab.com/gnutls/gnutls/issues/700
Author:    Tim Rühsen

In our 32bit MinGW runner, `long` seems to be 32bit. And thus this code is wrong:
static void
doOptMaxearlydata(tOptions* pOptions, tOptDesc* pOptDesc)
    static struct {long rmin, rmax;} const rng[1] = {
        { 1, 4294967296 } };

The value `4294967296` is `0` when put into a 32bit integer. Better to use `long long` or `uint64_t` or `4294967295`.

I didn't have time to look further into the code, so I can't judge what option is appropriate.

Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/issues/700
You're receiving this email because of your account on gitlab.com.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20190210/ff6b06fd/attachment.html>

More information about the Gnutls-devel mailing list