[gnutls-devel] GnuTLS | Fix 32bit overflow issue in src/serv-args.def (!922)

Development of GNU's TLS library gnutls-devel at lists.gnutls.org
Mon Feb 11 11:04:51 CET 2019


New Merge Request !922

https://gitlab.com/gnutls/gnutls/merge_requests/922

Branches: tmp-serv-args to master
Author:    Tim Rühsen
Assignee:  
Approvers: Simon Josefsson, Nikos Mavrogiannopoulos, Dmitry Eremin-Solenikov, Hubert Kario, Andreas Metzler, Daiki Ueno, Tom, Ander Juaristi, Tomáš Mráz, Anderson Sasaki and GnuTLS devel mailing list


Fixing this warning seen on 32bit architectures:
    
    serv-args.c: In function 'doOptMaxearlydata':
    serv-args.c:1431:14: warning: overflow in conversion from 'long long int' to 'long int' changes value from '4294967296' to '0' [-Woverflow]
             { 1, 4294967296 } };
                  ^~~~~~~~~~

Closes #700 

## Checklist
 * [ ] Code modified for feature
 * [ ] Test suite updated with functionality tests
 * [ ] Test suite updated with negative tests
 * [ ] Documentation updated / NEWS entry present (for non-trivial changes)

## Reviewer's checklist:
 * [ ] Any issues marked for closing are addressed
 * [ ] There is a test suite reasonably covering new functionality or modifications
 * [ ] Function naming, parameters, return values, types, etc., are consistent and according to `CONTRIBUTION.md`
 * [ ] This feature/change has adequate documentation added
 * [ ] No obvious mistakes in the code

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/merge_requests/922
You're receiving this email because of your account on gitlab.com.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20190211/0278f330/attachment.html>


More information about the Gnutls-devel mailing list