[gnutls-devel] GnuTLS | tests/slow/cipher-api-test.c: Make test more portable (!852)

Development of GNU's TLS library gnutls-devel at lists.gnutls.org
Wed Jan 2 11:46:55 CET 2019

> This test checks whether the abort signal is received from invalid use of gnutls calls.

*AND* it also tests that the functions return error. In case assert() has *not* been called, the test still PASSes as long as an error is returned. Thus your above statement is technically wrong (or not 100% correct).

My changes let assert() abort the program, and abortion is taken as success. I kept the code which checks the functions return value, just in case. If any of those cipher functions returns OK, the tests FAILs.

So the functionality of the test has not changed - it just doesn't rely on SIGABRT signal handlers. I could add a check `WIFSIGNALED(status) && WTERMSIG(status) == SIGABRT` to make 100% sure that not anything else caused program abortion, if that is what you are missing.

But if you like it better, I have no problem with going the `disable-non-portable` way.

Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/merge_requests/852#note_128352244
You're receiving this email because of your account on gitlab.com.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20190102/05614899/attachment.html>

More information about the Gnutls-devel mailing list