[gnutls-devel] GnuTLS | ext/session_ticket: eliminate redundant memcpy (!1040)

[Development of GNU's TLS library]

Tim Rühsen started a new discussion on lib/ext/session_ticket.c: https://gitlab.com/gnutls/gnutls/merge_requests/1040#note_189589054

>  	_gnutls_write_uint16(ticket->encrypted_state_len, p);
>  	p += 2;
>  
> -	memcpy(p, ticket->encrypted_state, ticket->encrypted_state_len);
> +	/* Encrypted state shall already be filled in by the caller. */

IMO, you should put an explanation here, like in the issue's description. That makes it much clearer what happens any why memmove is used.

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/merge_requests/1040#note_189589054
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20190708/830ffef6/attachment.html>